VIA 685: NextJS and Node version upgrade#584
Open
kieran-broomhall-nhs wants to merge 23 commits intomainfrom
Open
VIA 685: NextJS and Node version upgrade#584kieran-broomhall-nhs wants to merge 23 commits intomainfrom
kieran-broomhall-nhs wants to merge 23 commits intomainfrom
Conversation
…grade after node upgrade
…ignore from dependabot
kieran-broomhall-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
preprod
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
preprod
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
preprod
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
preprod
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
preprod
GitHub Actions
Inactive
kieran-broomhall-nhs
had a problem deploying
to
preprod
GitHub Actions
Failure
kieran-broomhall-nhs
had a problem deploying
to
preprod
GitHub Actions
Failure
kieran-broomhall-nhs
had a problem deploying
to
dev
GitHub Actions
Failure
kieran-broomhall-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
kieran-broomhall-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
| } | ||
|
|
||
| if ((await config.IS_APIM_AUTH_ENABLED) && isNodeJsRuntime) { | ||
| if (await config.IS_APIM_AUTH_ENABLED) { |
Contributor
There was a problem hiding this comment.
This means that in the middleware (which is called proxy.ts now IIRC) we will attempt to refresh the token, which we wouldn't have done before?
| "@opennextjs/aws": "^3.9.8", | ||
| "@types/aws-lambda": "^8.10.161", | ||
| "axios": "^1.13.6", | ||
| "axios": "^1.14.0", |
Contributor
There was a problem hiding this comment.
You mentioned about pinning the axios version, good time to do it now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated NextJS and Node versions
Context
This change is required as Next JS is going out of support towards the end of the year.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.